Drupal
Commit 155774 by webchick
#340052 by justinrandell: Speed up SimpleTest by 15,000 orders of magnitude by pre-loading the registry.
Commit 155744 by webchick
#340568 by Damien Tournoud: in some versions of SQLite, SELECT DISINCT(field) will return '(field)' as the field name.
Commit 155741 by webchick
#340500 by justinrandell: Fix silliness in install.inc that was loading the db system twice for no apparent reason.
Commit 155740 by webchick
Drupal: /includes/common.inc 1.832
#337794 by Damien Tournoud: Make SimpleTest work under PosthreSQL again.
Commit 155732 by webchick
Drupal: /includes/registry.inc 1.10
#338184 by Damien Tournoud: Remove special workarounds for serialize() in the registry.
drupal_is_front_page calls drupal_get_normal_path too often
I have a site which implements custom_url_rewrite_inbound(). I noticed this function was being called an obscene amount of times for many requests, when what I expected was for it to be called only once per request.
It turns out that drupal_get_normal_path calls custom_url_rewrite_inbound, and the latter is called with every request to drupal_is_front_page. Frankly, I'm not convinced these calls to drupal_is_front_page need to call drupal_get_normal_path, but the code is there so someone probably had a reason.
At any rate, the attached patch caches the front page path, so calls to drupal_get_normal_path and custom_url_rewrite_inbound only happen the first time drupal_is_front_page is called. With this patch applied, custom_url_rewrite_inbound() is called twice per request. Once when it is actually needed, to rewrite the incoming request. And a second time to rewrite the front page path, which as I said earlier I'm not convinced is actually necessary or good.
Commit 155640 by dries
Drupal: /modules/menu/menu.test 1.5
Drupal: /modules/poll/poll.test 1.11
Drupal: /modules/simpletest/drupal_web_test_case.php 1.63
Drupal: /modules/system/system.install 1.290
Drupal: /modules/user/user.module 1.944
Drupal: /robots.txt 1.13
- Patch #337820 by Dave Reid, Damien Tournoud, et al: rename menu path 'logout' to 'user/logout'. For real now.
Commit 155638 by dries
Drupal: /includes/database/mysql/database.inc 1.9
Drupal: /includes/database/pgsql/database.inc 1.11
Drupal: /includes/database/sqlite/database.inc 1.3
- Patch #337926 by hswong3i, Dave Reid, Damien Tournoud: forced connection with PDF:CASE_LOWER.
Bug in PHP moves uploads with wrong permissions
This is really sort of a bug in PHP as discussed here. In the discussion a suggestion is done to always do a chmod after using move_uploaded_file(). In Drupal this advice however is ignored, causing permission problems when files are uploaded with the faulty versions of PHP. The moved files get permission 600 and become therefore unreadable except for Apache. I suggest chmod 644 is added in the code.
Commit 155500 by dries
- Patch #281131 by Damien Tournoud: document the missing quote in .htaccess.
Commit 155499 by dries
- Patch #281131 by Damien Tournoud: document the missing quote in .htaccess.
Commit 155498 by dries
- Patch #339960 by Damien Tournoud: updated test explanation.
Commit 155497 by dries
Drupal: /includes/database/pgsql/database.inc 1.10
Drupal: /includes/database/sqlite/database.inc 1.2
- Patch #337926 by hswong3i: by default, force lower-case database tables/columns.
Commit 155496 by dries
- Patch #248205 by Damien Tournoud: up requirement for PostgreSQL to PostgreSQL 8.3.
Alias languages are not being displayed correctly
I had a few nodes that were all written in Dutch. Pathauto had made aliases for those nodes, but only for one of them the alias was actually being used. The problem was that only one of those aliases was to be used for all languages, while the rest was for English only (A little remnant from the early stages of development when I had set English to be the default language and Dutch was only secondary, not English has been disabled completely). The admin panel at /admin/build/path told me all aliases were to be used for all languages, while a quick peek in phpMyAdmin showed that most aliases were indeed to be used for English only. This is a Drupal problem, since Drupal didn't correctly display the values saved in the DB.
In other words: Drupal doesn't accurately indicate for what languages existing aliases are to be used at /admin/build/path.
Commit 155285 by webchick
#338239 follow-up by c960657: Fix file test failure.
Commit 155282 by webchick
Drupal: /modules/poll/poll.test 1.10
Drupal: /modules/simpletest/drupal_web_test_case.php 1.62
Drupal: /modules/system/system.install 1.289
Drupal: /modules/user/user.module 1.943
Drupal: /robots.txt 1.12
Reverting #337820 once more, as it causes mysterious test failures.
Commit 155175 by dries
Drupal: /modules/system/system.test 1.27
- Patch #314870 by drewish: removed some code that accidentically got committed with api.php and that broke the tests.
Commit 155150 by dries
- Patch #325908 by kbahey: removed redundant cache flusing.
Commit 155149 by dries
- Patch #325908 by kbahey: removed redundant cache flusing.