Drupal

Commit 155774 by webchick

CVS Core Commit Messages - Sun, 11/30/2008 - 3:04am
Commit #155774 by webchick at 07:04 Drupal: /modules/simpletest/drupal_web_test_case.php 1.64
  #340052 by justinrandell: Speed up SimpleTest by 15,000 orders of magnitude by pre-loading the registry.
Categories: Drupal

Commit 155744 by webchick

CVS Core Commit Messages - Sat, 11/29/2008 - 9:26pm
Commit #155744 by webchick at 01:26 Drupal: /includes/database/sqlite/database.inc 1.4
  #340568 by Damien Tournoud: in some versions of SQLite, SELECT DISINCT(field) will return '(field)' as the field name.
Categories: Drupal

Commit 155741 by webchick

CVS Core Commit Messages - Sat, 11/29/2008 - 9:11pm
Commit #155741 by webchick at 01:11 Drupal: /includes/install.inc 1.78
  #340500 by justinrandell: Fix silliness in install.inc that was loading the db system twice for no apparent reason.
Categories: Drupal

Commit 155740 by webchick

CVS Core Commit Messages - Sat, 11/29/2008 - 9:05pm
Commit #155740 by webchick at 01:05 Drupal: /includes/bootstrap.inc 1.256
Drupal: /includes/common.inc 1.832
  #337794 by Damien Tournoud: Make SimpleTest work under PosthreSQL again.
Categories: Drupal

Commit 155732 by webchick

CVS Core Commit Messages - Sat, 11/29/2008 - 7:21pm
Commit #155732 by webchick at 23:21 Drupal: /includes/bootstrap.inc 1.255
Drupal: /includes/registry.inc 1.10
  #338184 by Damien Tournoud: Remove special workarounds for serialize() in the registry.
Categories: Drupal

drupal_is_front_page calls drupal_get_normal_path too often

Pending bugs in Drupal 6 - Sat, 11/29/2008 - 12:22pm

I have a site which implements custom_url_rewrite_inbound(). I noticed this function was being called an obscene amount of times for many requests, when what I expected was for it to be called only once per request.

It turns out that drupal_get_normal_path calls custom_url_rewrite_inbound, and the latter is called with every request to drupal_is_front_page. Frankly, I'm not convinced these calls to drupal_is_front_page need to call drupal_get_normal_path, but the code is there so someone probably had a reason.

At any rate, the attached patch caches the front page path, so calls to drupal_get_normal_path and custom_url_rewrite_inbound only happen the first time drupal_is_front_page is called. With this patch applied, custom_url_rewrite_inbound() is called twice per request. Once when it is actually needed, to rewrite the incoming request. And a second time to rewrite the front page path, which as I said earlier I'm not convinced is actually necessary or good.

Categories: Drupal

Bug in PHP moves uploads with wrong permissions

Pending bugs in Drupal 6 - Fri, 11/28/2008 - 2:32pm

This is really sort of a bug in PHP as discussed here. In the discussion a suggestion is done to always do a chmod after using move_uploaded_file(). In Drupal this advice however is ignored, causing permission problems when files are uploaded with the faulty versions of PHP. The moved files get permission 600 and become therefore unreadable except for Apache. I suggest chmod 644 is added in the code.

Categories: Drupal

Commit 155500 by dries

CVS Core Commit Messages - Fri, 11/28/2008 - 5:39am
Commit #155500 by Dries at 09:39 Drupal: /.htaccess 1.90.2.2 @ DRUPAL-6
  - Patch #281131 by Damien Tournoud: document the missing quote in .htaccess.
Categories: Drupal

Commit 155499 by dries

CVS Core Commit Messages - Fri, 11/28/2008 - 5:39am
Commit #155499 by Dries at 09:39 Drupal: /.htaccess 1.98
  - Patch #281131 by Damien Tournoud: document the missing quote in .htaccess.
Categories: Drupal

Commit 155498 by dries

CVS Core Commit Messages - Fri, 11/28/2008 - 5:34am
Commit #155498 by Dries at 09:34 Drupal: /modules/comment/comment.test 1.20
  - Patch #339960 by Damien Tournoud: updated test explanation.
Categories: Drupal

Commit 155497 by dries

CVS Core Commit Messages - Fri, 11/28/2008 - 5:27am
Commit #155497 by Dries at 09:27 Drupal: /includes/database/mysql/database.inc 1.8
Drupal: /includes/database/pgsql/database.inc 1.10
Drupal: /includes/database/sqlite/database.inc 1.2
  - Patch #337926 by hswong3i: by default, force lower-case database tables/columns.
Categories: Drupal

Commit 155496 by dries

CVS Core Commit Messages - Fri, 11/28/2008 - 5:26am
Commit #155496 by Dries at 09:26 Drupal: /modules/system/system.module 1.650
  - Patch #248205 by Damien Tournoud: up requirement for PostgreSQL to PostgreSQL 8.3.
Categories: Drupal

Alias languages are not being displayed correctly

Pending bugs in Drupal 6 - Thu, 11/27/2008 - 11:07am

I had a few nodes that were all written in Dutch. Pathauto had made aliases for those nodes, but only for one of them the alias was actually being used. The problem was that only one of those aliases was to be used for all languages, while the rest was for English only (A little remnant from the early stages of development when I had set English to be the default language and Dutch was only secondary, not English has been disabled completely). The admin panel at /admin/build/path told me all aliases were to be used for all languages, while a quick peek in phpMyAdmin showed that most aliases were indeed to be used for English only. This is a Drupal problem, since Drupal didn't correctly display the values saved in the DB.

In other words: Drupal doesn't accurately indicate for what languages existing aliases are to be used at /admin/build/path.

Categories: Drupal

Commit 155285 by webchick

CVS Core Commit Messages - Thu, 11/27/2008 - 4:41am
Commit #155285 by webchick at 08:41 Drupal: /modules/simpletest/tests/file.test 1.14
  #338239 follow-up by c960657: Fix file test failure.
Categories: Drupal

Commit 155175 by dries

CVS Core Commit Messages - Wed, 11/26/2008 - 2:56pm
Commit #155175 by Dries at 18:56 Drupal: /modules/system/system.module 1.649
Drupal: /modules/system/system.test 1.27
  - Patch #314870 by drewish: removed some code that accidentically got committed with api.php and that broke the tests.
Categories: Drupal

Commit 155150 by dries

CVS Core Commit Messages - Wed, 11/26/2008 - 9:54am
Commit #155150 by Dries at 13:54 Drupal: /modules/system/system.admin.inc 1.63.2.5 @ DRUPAL-6
  - Patch #325908 by kbahey: removed redundant cache flusing.
Categories: Drupal

Commit 155149 by dries

CVS Core Commit Messages - Wed, 11/26/2008 - 9:54am
Commit #155149 by Dries at 13:54 Drupal: /modules/system/system.admin.inc 1.110
  - Patch #325908 by kbahey: removed redundant cache flusing.
Categories: Drupal
Syndicate content